Skip to content

Conversation

@stevenroose
Copy link
Contributor

@stevenroose stevenroose commented Apr 16, 2020

Backport of #861.

Without his change, invalid addresses are converted into fee outputs.
@gwillen
Copy link
Contributor

gwillen commented Apr 16, 2020

Diff looks the same as the backported MR:

bunneh:elements gwillen$ git range-diff upstream/pr/867^^..upstream/pr/867 upstream/pr/861^^..upstream/pr/861
1:  21b3913a7 = 1:  1b8bf85d8 Make issuance fail for invalid addresses
2:  8e5893ecb = 2:  425691623 Add test to make sure issuances to wrong addresses fail

(I guess that's a utACK? I'm never clear on how reviewing for backports is meant to work.)

@stevenroose
Copy link
Contributor Author

Epic command!

@stevenroose stevenroose merged commit 292f9f5 into ElementsProject:elements-0.18 Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants