-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign PSET #900
Redesign PSET #900
Commits on Jun 3, 2021
-
Remove PSET and disable PSBT/PSET things for now
Reset back to Bitcoin PSBT and disable PSBT/PSET handling in wallet and rpc. This is just a reset to allow for PSBTv2 change and then a new and improved PSET.
Configuration menu - View commit details
-
Copy full SHA for fdf71de - Browse repository at this point
Copy the full SHA fdf71deView commit details -
Configuration menu - View commit details
-
Copy full SHA for e882a3a - Browse repository at this point
Copy the full SHA e882a3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50c281f - Browse repository at this point
Copy the full SHA 50c281fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad2b2d7 - Browse repository at this point
Copy the full SHA ad2b2d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25c13ad - Browse repository at this point
Copy the full SHA 25c13adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 575fec0 - Browse repository at this point
Copy the full SHA 575fec0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bb930e - Browse repository at this point
Copy the full SHA 5bb930eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31a7e0a - Browse repository at this point
Copy the full SHA 31a7e0aView commit details
Commits on Jun 22, 2021
-
moveonly: Move (Un)Serialize(To/From)Vector, (De)SerializeHDKeypaths …
…to psbt module SerializeToVector, UnserializeFromVector, DeserializeHDKeypaths, and SerializeHDKeypaths were in sign.h where PSBT was originally implemented. Since all of the PSBT serialization has moved to its own file, these functions should follow.
Configuration menu - View commit details
-
Copy full SHA for fad29ba - Browse repository at this point
Copy the full SHA fad29baView commit details -
Store version bytes and be able to serialize them in CExtPubKey
CExtPubKey does not store the version bytes for the extended public key. We store these so that a CExtPubKey can be serialized and deserialized with the same version bytes.
Configuration menu - View commit details
-
Copy full SHA for cb9c553 - Browse repository at this point
Copy the full SHA cb9c553View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4eabba9 - Browse repository at this point
Copy the full SHA 4eabba9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b5c5ef - Browse repository at this point
Copy the full SHA 5b5c5efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c54175 - Browse repository at this point
Copy the full SHA 2c54175View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fd50b2 - Browse repository at this point
Copy the full SHA 7fd50b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc2651d - Browse repository at this point
Copy the full SHA bc2651dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20e8dff - Browse repository at this point
Copy the full SHA 20e8dffView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec03f83 - Browse repository at this point
Copy the full SHA ec03f83View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd792ce - Browse repository at this point
Copy the full SHA dd792ceView commit details -
Change PSBT unknown fields test to use higher numbers
Previously these tests were using 0x0f as the field number. Changed to use 0xf0 instead as it is unlikely we will hit that anytime soon.
Configuration menu - View commit details
-
Copy full SHA for 8c62443 - Browse repository at this point
Copy the full SHA 8c62443View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2042765 - Browse repository at this point
Copy the full SHA 2042765View commit details -
Enforce PSBT version constraints
With PSBTv2, some fields are not allowed in PSBTv2, and some are required. Enforce those.
Configuration menu - View commit details
-
Copy full SHA for 457b6bd - Browse repository at this point
Copy the full SHA 457b6bdView commit details -
Add PSBT::CacheUnsignedTxPieces
Fetches the PSBTv2 fields from PSBTv0's global unsigned tx. This allows us to pretend everything internally is a PSBTv2 and makes things easier to work with.
Configuration menu - View commit details
-
Copy full SHA for c32950e - Browse repository at this point
Copy the full SHA c32950eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32234df - Browse repository at this point
Copy the full SHA 32234dfView commit details -
Convert PSBTv0 unsigned tx to PSBTv2 fields
This is just a convenience and doesn't effect serialization.
Configuration menu - View commit details
-
Copy full SHA for 4b805fd - Browse repository at this point
Copy the full SHA 4b805fdView commit details -
Replace PSBT::GetInputUTXO with PSBTInput::GetUTXO
Now that PSBTInput's track their own prevouts, there's no need for a PSBT global function to fetch input specific data.
Configuration menu - View commit details
-
Copy full SHA for 3c647b7 - Browse repository at this point
Copy the full SHA 3c647b7View commit details -
Function to compute the lock time for the transaction
Configuration menu - View commit details
-
Copy full SHA for 10bf247 - Browse repository at this point
Copy the full SHA 10bf247View commit details -
A helper function for getting the unsigned transaction regardless of psbt version.
Configuration menu - View commit details
-
Copy full SHA for 32bdf2d - Browse repository at this point
Copy the full SHA 32bdf2dView commit details -
The unique ID for PSBTv2 is different from v0. Use this function to get the ID without requiring the caller to know the version number.
Configuration menu - View commit details
-
Copy full SHA for bd1a57b - Browse repository at this point
Copy the full SHA bd1a57bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90cd7ec - Browse repository at this point
Copy the full SHA 90cd7ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd5515a - Browse repository at this point
Copy the full SHA cd5515aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ff2593 - Browse repository at this point
Copy the full SHA 4ff2593View commit details -
Helper for getting the PSBTInput COutPoint
Configuration menu - View commit details
-
Copy full SHA for d8dba33 - Browse repository at this point
Copy the full SHA d8dba33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23f6442 - Browse repository at this point
Copy the full SHA 23f6442View commit details -
Configuration menu - View commit details
-
Copy full SHA for f269d11 - Browse repository at this point
Copy the full SHA f269d11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 500554a - Browse repository at this point
Copy the full SHA 500554aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9c23ca - Browse repository at this point
Copy the full SHA c9c23caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c83300 - Browse repository at this point
Copy the full SHA 9c83300View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16395c1 - Browse repository at this point
Copy the full SHA 16395c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 139ac36 - Browse repository at this point
Copy the full SHA 139ac36View commit details -
Configuration menu - View commit details
-
Copy full SHA for bedc1e0 - Browse repository at this point
Copy the full SHA bedc1e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a34474e - Browse repository at this point
Copy the full SHA a34474eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e467ec6 - Browse repository at this point
Copy the full SHA e467ec6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c1fe58 - Browse repository at this point
Copy the full SHA 2c1fe58View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebc49e3 - Browse repository at this point
Copy the full SHA ebc49e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4bca18 - Browse repository at this point
Copy the full SHA f4bca18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ca0b7e - Browse repository at this point
Copy the full SHA 0ca0b7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e860cd0 - Browse repository at this point
Copy the full SHA e860cd0View commit details -
Use GetUnsignedTx when serializing in PSBTv0
If we are asked to make a PSBTv0, we may not necessarily have made an unsigned transaction. So instead use GetUnsignedTx which will either fetch one that already exists, or construct a new one from the stored data. Internally we may be storing a PSBTv0 like a PSBTv2, but still want to serialize those as v0.
Configuration menu - View commit details
-
Copy full SHA for ecaf5ea - Browse repository at this point
Copy the full SHA ecaf5eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b372430 - Browse repository at this point
Copy the full SHA b372430View commit details -
Configuration menu - View commit details
-
Copy full SHA for e374397 - Browse repository at this point
Copy the full SHA e374397View commit details -
Configuration menu - View commit details
-
Copy full SHA for f84a927 - Browse repository at this point
Copy the full SHA f84a927View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee28be3 - Browse repository at this point
Copy the full SHA ee28be3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33c694f - Browse repository at this point
Copy the full SHA 33c694fView commit details -
Return peg-in UTXO with GetUTXO
Peg-ins don't have a typical UTXO. Instead we can get a "UTXO" using the peg-in data.
Configuration menu - View commit details
-
Copy full SHA for 2220d84 - Browse repository at this point
Copy the full SHA 2220d84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6890461 - Browse repository at this point
Copy the full SHA 6890461View commit details -
The asset issuance details are added to createpsbt and walletcreatefundedpsbt.
Configuration menu - View commit details
-
Copy full SHA for 79c4a99 - Browse repository at this point
Copy the full SHA 79c4a99View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdfcb43 - Browse repository at this point
Copy the full SHA bdfcb43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dbc3b2 - Browse repository at this point
Copy the full SHA 1dbc3b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7dd046 - Browse repository at this point
Copy the full SHA e7dd046View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f6c8bf - Browse repository at this point
Copy the full SHA 3f6c8bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a450ec - Browse repository at this point
Copy the full SHA 9a450ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for bad1876 - Browse repository at this point
Copy the full SHA bad1876View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6cc0fd - Browse repository at this point
Copy the full SHA e6cc0fdView commit details -
Remove output_assets and have asset field in outputs
Instead of having an output_assets argument to createpsbt, createrawtransaction, and walletcreatefundedpsbt, move the asset specification into the outputs array itself. This also removes the backwards compatibility of using a dict for outputs in createrawtransaction.
Configuration menu - View commit details
-
Copy full SHA for ea2c3df - Browse repository at this point
Copy the full SHA ea2c3dfView commit details -
Output PSBTOutputs with aux info from ConstructTransaction
Output PSBTOutputs with blinding pubkey and index info from ConstructTransaction so that these can be added to PSBTs later.
Configuration menu - View commit details
-
Copy full SHA for 5391095 - Browse repository at this point
Copy the full SHA 5391095View commit details -
Configuration menu - View commit details
-
Copy full SHA for f686e0f - Browse repository at this point
Copy the full SHA f686e0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 124efa2 - Browse repository at this point
Copy the full SHA 124efa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8a6f4c - Browse repository at this point
Copy the full SHA a8a6f4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3db2622 - Browse repository at this point
Copy the full SHA 3db2622View commit details -
Configuration menu - View commit details
-
Copy full SHA for eeb6cf7 - Browse repository at this point
Copy the full SHA eeb6cf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9bfff2 - Browse repository at this point
Copy the full SHA e9bfff2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25df8aa - Browse repository at this point
Copy the full SHA 25df8aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c0cee5 - Browse repository at this point
Copy the full SHA 2c0cee5View commit details -
Allow value commitments instead of explicit value
It is not invalid to have a value commitment and no explicit value. It is only invalid to have neither for an output.
Configuration menu - View commit details
-
Copy full SHA for c0cb623 - Browse repository at this point
Copy the full SHA c0cb623View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd97836 - Browse repository at this point
Copy the full SHA bd97836View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e2f1ff - Browse repository at this point
Copy the full SHA 0e2f1ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8fa5c1 - Browse repository at this point
Copy the full SHA d8fa5c1View commit details -
Remove walletsignpsbt, blindpsbt, walletblindpsbt, and
walletfillpsbtdata These are all done by walletprocesspsbt
Configuration menu - View commit details
-
Copy full SHA for b1ebc81 - Browse repository at this point
Copy the full SHA b1ebc81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46ccf61 - Browse repository at this point
Copy the full SHA 46ccf61View commit details -
Configuration menu - View commit details
-
Copy full SHA for afd7950 - Browse repository at this point
Copy the full SHA afd7950View commit details -
Remove unnecessary psbt blinding test
This test is for a condition that no longer matters. Prior to CA, there was only the single value blinder for a transaction that sent unconf to conf. This would necessitate setting that single blinding factor to 0, which would make the single output not actually blinded. But with CA, because each output has an additional blinding factor for the asset, this issue no longer exists.
Configuration menu - View commit details
-
Copy full SHA for 1889554 - Browse repository at this point
Copy the full SHA 1889554View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80ff739 - Browse repository at this point
Copy the full SHA 80ff739View commit details -
Helper function for getting a CTxOut for a PSBTOutput
Configuration menu - View commit details
-
Copy full SHA for b65a00f - Browse repository at this point
Copy the full SHA b65a00fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64b30bf - Browse repository at this point
Copy the full SHA 64b30bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7533503 - Browse repository at this point
Copy the full SHA 7533503View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fe6401 - Browse repository at this point
Copy the full SHA 9fe6401View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a44ff2 - Browse repository at this point
Copy the full SHA 4a44ff2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4940cee - Browse repository at this point
Copy the full SHA 4940ceeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5425da4 - Browse repository at this point
Copy the full SHA 5425da4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 864f625 - Browse repository at this point
Copy the full SHA 864f625View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8553c5 - Browse repository at this point
Copy the full SHA f8553c5View commit details