Fix parsing of amount commitments from prevtxs in signrawtrasnactionwithkey #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwillen
force-pushed
the
feature-fix-signraw-commitment
branch
from
64084f5
to
29ca418
Compare
|
Travis failure is a consequence of the issue fixed by #905, unrelated to this PR. |
|
Can you rebase now that CI passes again? :) |
gwillen
force-pushed
the
feature-fix-signraw-commitment
branch
from
29ca418
to
a4045d2
Compare
|
Rebased. |
|
@stevenroose Can you kick CI to retry (or let me know how?) There are two failures, one is just a spurious timeout, the other one is in an unrelated test and might also be a timeout of some sort (or I'm not sure what's going on with it.) |
|
ack a4045d2 |
stevenroose
added a commit
that referenced
this pull request
Sep 22, 2020
fbdb9f3 Add signrawtransaction test for input of amountcommitment. (k-matsuzawa) Pull request description: - This test assumes a fix for #904. Before correction, the test will result in an error. - I splited the node network in rpc_signrawtransaction.py to do this test. - For now, I have only created one test case. Are there any other test cases that should be added? Tree-SHA512: 842eba8a673e4e7d416de54f8ef40c63aad83b4a33f21401c4fde8c7b66008ac3fc6d87334f1bac22ffa8c0186e0b531f246f1a3a7afa45faaa0ea2336f6f865
stevenroose
added a commit
that referenced
this pull request
Oct 6, 2020
…itments from prevtxs in signrawtransactionw… 4e31616 Fix parsing of amount commitments from prevtxs in signrawtransactionwithkey (Glenn Willen) Pull request description: Tree-SHA512: ead69e32fb14ee85f776f786f8510df1b71432e2f3fa02588913c94566219d7b951987162be205269a67acc8b1f1cca84e78278b4bb28fb129b9ca339cda1672
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Dec 3, 2020
Manually applied this one from the original diff.
gwillen
pushed a commit
that referenced
this pull request
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.