-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin clnrest improvements #6436
Comments
Hey @ShahanaFarooqui if you're not already working on clnrest tests I'd like to write some tests for clnrest plugin. Is it okay for you? |
@tonyaldon Hey, perfect timing. I was about to start it today. Please go ahead and let me know if you need any information regarding it. BTW, you can refer to |
Cool! I'll work on it. Thanks for the reference to grpc test. |
For posterity:
Done.
Introduced CORS and CSP configuration options but not including CSRF till there is no absolute need because:
Websocket Server support for browser was already available but it did not have rune authentication. Added the authentication and an html/js example in |
Please link your PR with this issue as well once it is drafted/ready for review. |
- cln-grpc certificate reuse - new certificate generation - `GET` and `POST` requests - websocket server - config options and HTTP headers Link to ElementsProject#6436.
- cln-grpc certificate reuse - new certificate generation - `GET` and `POST` requests - websocket server - config options and HTTP headers Link to ElementsProject#6436.
- cln-grpc certificate reuse - new certificate generation - `GET` and `POST` requests - websocket server - config options and HTTP headers Link to ElementsProject#6436.
- cln-grpc certificate reuse - new certificate generation - `GET` and `POST` requests - websocket server - config options and HTTP headers Link to ElementsProject#6436.
- cln-grpc certificate reuse - new certificate generation - `GET` and `POST` requests - websocket server - config options and HTTP headers Link to ElementsProject#6436.
- cln-grpc certificate reuse - new certificate generation - `GET` and `POST` requests - websocket server - config options and HTTP headers Link to ElementsProject#6436.
- cln-grpc certificate reuse - new certificate generation - `GET` and `POST` requests - websocket server - config options and HTTP headers Link to #6436.
Generate client, server & CA certs.
Write automated testcases
Add configurable CSRF, CORS & CSP options
Add websocket server support for browsers too
Reported by @ddustin on Discord
"It looks like the web browser based websocket api does not allow custom http headers. so I believe, in it's current form,
clnrest isn't usable in a web browser -- was that intentional? perhaps we could move the rune and node id to another field (uri
or websocket message) so we're compatible with web browsers. Here are four common solutions to the problem:
https://websockets.readthedocs.io/en/stable/topics/authentication.html"
The text was updated successfully, but these errors were encountered: