-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal error ONCHAIN: HTLC in 2053 invalid update SENT_ADD_ACK_COMMIT->SENT_REMOVE_HTLC #8176
Milestone
Comments
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Apr 1, 2025
We pre-close incoming under some circumstances, so this does happen (it didn't when this code was written). Don't walk all the HTLCs complaining about them in this case, and don't freak out. Changelog-Fixed: lightningd: incorrect spamming of log and potential crash on testnet case of duplicate HTLCs and slow closing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#8176
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Apr 2, 2025
We pre-close incoming under some circumstances, so this does happen (it didn't when this code was written). Don't walk all the HTLCs complaining about them in this case, and don't freak out. Changelog-Fixed: lightningd: incorrect spamming of log and potential crash on testnet case of duplicate HTLCs and slow closing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#8176
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Apr 2, 2025
We pre-close incoming under some circumstances, so this does happen (it didn't when this code was written). Don't walk all the HTLCs complaining about them in this case, and don't freak out. Changelog-Fixed: lightningd: incorrect spamming of log and potential crash on testnet case of duplicate HTLCs and slow closing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#8176
endothermicdev
pushed a commit
that referenced
this issue
Apr 4, 2025
We pre-close incoming under some circumstances, so this does happen (it didn't when this code was written). Don't walk all the HTLCs complaining about them in this case, and don't freak out. Changelog-Fixed: lightningd: incorrect spamming of log and potential crash on testnet case of duplicate HTLCs and slow closing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: #8176
endothermicdev
pushed a commit
that referenced
this issue
Apr 4, 2025
We pre-close incoming under some circumstances, so this does happen (it didn't when this code was written). Don't walk all the HTLCs complaining about them in this case, and don't freak out. Changelog-Fixed: lightningd: incorrect spamming of log and potential crash on testnet case of duplicate HTLCs and slow closing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: #8176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Crashes on restart on multiple HTLCs with failonion in testnet. No idea how to proceed.
Head
The text was updated successfully, but these errors were encountered: