Reconnect after feerate bad sig fix #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1. l1 update_fee -> l2 2. l1 commitment_signed -> l2 (using new feerate) 3. l1 <- revoke_and_ack l2 4. l1 <- commitment_signed l2 (using new feerate) 5. l1 -> revoke_and_ack l2 When we break the connection after #3, the reconnection causes #4 to be retransmitted, but it turns out l1 wasn't telling the master to set the local feerate until it received the commitment_signed, so on reconnect it uses the old feerate, with predictable results (bad signature). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/feerate-bad-sig-fix
branch
from
98f172d
to
1a1ccb9
Compare
Merged
cdecker
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis found this for #1846 but that's just because we send feerate adjustments more.