hsmd: Added fields to hsm_sign_remote_commitment_tx to allow complete validation. #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bitcoin-bot was offline for a couple of hours, he should be back now :-) |
cdecker
force-pushed
the
hsmd-add-fields1
branch
from
c9cbf04
to
33d756b
Compare
cdecker
reviewed
Jan 6, 2020
|
Some minor things that could be simplified, but overall I'm all for giving the |
There was a problem hiding this comment.
Only minor changes suggested, this is really good work!
(Sorry for the delayed feedback, I was on vacation and am now catching up!).
Orthogonal to this, I wonder if we should bite the bullet and use struct witscript everywhere for type-safety. That's a bigger change though, and may involve changing it to a danlging u8 rather than a pointer, to avoid adding allocations.
|
👍 type safety |
…motekey to hsm_sign_remote_commitment_tx to allow complete validation.
…to allow complete validation by signing daemon.
ksedgwic
force-pushed
the
hsmd-add-fields1
branch
from
829953c
to
c85c05b
Compare
cdecker
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added output_witscripts, remote_per_commit and option_static_remotekey to hsm_sign_remote_commitment_tx to allow complete validation.