Wumbo channel support #3612
Merged
Wumbo channel support #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
added
spec
Optech Make Me Famous!
rustyrussell
force-pushed
the
guilt/wumbo
branch
from
7699065
to
e816d77
Compare
cdecker
approved these changes
Apr 1, 2020
common/features.c
Outdated
Comment on lines
157
to
158
| const struct feature_set *ours, | ||
| const u8 *theirfeatures) |
There was a problem hiding this comment.
Nit: inconsistent naming, should be theirs and ours, or theirfeaturesandourfeatures`.
Comment on lines
+740
to
+741
| else | ||
| continue; |
There was a problem hiding this comment.
This should likely at least produce a warning that the plugin is not in sync with lightningd
There was a problem hiding this comment.
I figure it's always legal to add a field. Though perhaps libplugin should consider itself more tightly bound?
This will help with the next patch, where we wean off using a global for features: connectd.c has access to the feature bits. Since connectd might now want to send a message, it needs the crypto_state non-const, which makes this less trivial than it would otherwise be. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Turns out that unnecessary: all callers can access the feature_set, so make it much more like a normal primitive. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Shows what features we use in various contexts, including those added by plugins in getmanifest. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: Plugin: `feature_set` object added to `init`
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is useful in general, but in particular it allows fundchannel to avoid YA query to figure out if it can wumbo. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: JSON: `connect` returns `features` of the connected peer on success.
This means we correctly reject invoices with features we don't understand. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/wumbo
branch
3 times, most recently
from
b7fa526
to
d50abc3
Compare
|
OK, I fixed some tests, and did a sweep to rename all the feature sets to "our_features" or "their_features" where appropriate. |
rustyrussell
force-pushed
the
guilt/wumbo
branch
from
d50abc3
to
7f7b69e
Compare
…arge_channel. Note that now we check capacity once we've figured out which peer, which broke a test (we returned "unknown peer" instead of "capacity exceeded"), so we rework that too. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-added: `large-channels` option to negotiate opening larger channels.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…icit. It's almost always "their_features" and "our_features" respectively, so make those names clear. Suggested-by: @cdecker Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/wumbo
branch
from
7f7b69e
to
6ea51f0
Compare
|
Ack 6ea51f0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--wumbo(or, more prosiacly) a--large-channelsoption (off by default) which means:option_support_large_channelfrom the spec.Before merging, someone should interop this with Eclair: in particular, it's the first feature we advertize in the channel_announcement, and we can't advertize the channel if we don't both agree on how that's represented!