Fix fundchannel in deprecated-apis=false mode ('satoshi' param in fundchannel_start)

[darosior]

Noticed while testing #3611 49e2153 kept satoshi but did not make fundchannel_start accept it again.

Note that we run the functional tests with deprecated-apis=false so we did not catch this, but users run with deprecated-apis=true..

[darosior]

Note that we run the functional tests with deprecated-apis=false so we did not catch this, but users run with deprecated-apis=true..

Cf #3616

[rustyrussell]

No, it was the output parameter satoshi we can't deprecate. I definitely meant to deprecate the input.

Was there a reason to defer this?

[darosior]

Ah, ok then it becomes way simpler :-) Amended the commit.

[cdecker]

ACK eced481

[cdecker]

Notice that the help text in the json command further down still mentions satoshi (wrongfully since the param was always called amount). I'll add that to my cleanups for this weak.

[darosior]

Notice that the help text in the json command further down still mentions satoshi (wrongfully since the param was always called amount). I'll add that to my cleanups for this weak.

Thanks