channeld: defer first update_fee until we have an HTLC to send. #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this fixes #3341 too. |
|
Seems some more tests require porting to the new behavior:
|
iirc in this one we make |
rustyrussell
force-pushed
the
guilt/defer-fee-update
branch
from
7e6af8b
to
6b64922
Compare
|
Hmm, somehow I missed that failure. Easy to fix, just added a HTLC to make update_fee work. |
rustyrussell
force-pushed
the
guilt/defer-fee-update
branch
2 times, most recently
from
f575115
to
6c4d5c9
Compare
Sending update_fee immediately after channel establishment seems to upset LND, so work around it by deferring it. The reason we increase the fee after establishment is because now we might need to close the channel in a hurry due to htlcs, but until there are htlcs that's unnecessary. Fixes: ElementsProject#3596 Changelog-Changed: Added workaround for lnd rejecting our commitment_signed when we send an update_fee after channel confirmed. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/defer-fee-update
branch
from
6c4d5c9
to
462e62e
Compare
|
ACK 462e62e |
This was referenced Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending update_fee immediately after channel establishment seems to
upset LND, so work around it by deferring it. The reason we increase
the fee after establishment is because now we might need to close the
channel in a hurry due to htlcs, but until there are htlcs that's
unnecessary.
Workaround for #3596
Signed-off-by: Rusty Russell rusty@rustcorp.com.au