Implement keysend sending support for spontaneous payments
#3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
added
feature
Optech Make Me Famous!
cdecker
force-pushed
the
paymod-03
branch
2 times, most recently
from
414efa3 to
7b65e85
Compare
cdecker
force-pushed
the
paymod-03
branch
2 times, most recently
from
fd1eb65 to
8715eb1
Compare
cdecker
force-pushed
the
paymod-03
branch
4 times, most recently
from
f0602e8 to
29f9a7e
Compare
cdecker
force-pushed
the
paymod-03
branch
3 times, most recently
from
f97fd2c to
8ebcef8
Compare
cdecker
force-pushed
the
keysend
branch
2 times, most recently
from
d7e0265 to
a15ef99
Compare
cdecker
force-pushed
the
paymod-03
branch
4 times, most recently
from
8ac4e2e to
b606f46
Compare
cdecker
force-pushed
the
keysend
branch
2 times, most recently
from
1fb3a9c to
12886fb
Compare
rustyrussell
reviewed
Jul 8, 2020
This makes use of the payment modifier structure to just add the preimage to the TLV payload for the last hop. Changelog-Added: JSON-RPC: The `keysend` command allows sending to a node without requiring an invoice first.
Allows us to do fewer allocations, since the argument doesn't have to be tal allocated itself. Suggested-by: Rusty Russell <@rustyrussell>
1 task
|
Out of curiosity, does this supersede #3611 or simply build on top of it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a long time in the making, but we finally are able to build new features on top of the paymod series.
This modifier is rather simple, but that's all it takes: add the payment preimage, that we generate randomly, into the onion payload for the final hop, so a recipient that knows to look for it can claim the incoming payment.
Todo
lightning-cli keysend