More psbt cleanups #3958
Merged
More psbt cleanups #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It can now handle all the metadata as well as the base tx input. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
ZmnSCPxj
approved these changes
Aug 20, 2020
Most of what it does was actually a function of adding the input metadata to the PSBT, so call that and simply copy out the tx input it creates. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
more-psbt-cleanups
branch
from
0b4ccc3
to
fac7902
Compare
ZmnSCPxj
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this for adding an input to a PSBT, but it also moves us closer to weaning off bitcoin_tx...
Changelog-None