-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fees on listpeers rpc output #4247
feat: fees on listpeers rpc output #4247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8dbe6f1
Minor quibble about docs but not enough to block this.
8dbe6f1
to
956a769
Compare
OK, so minor feedback:
|
This will add `fee_base` (msat) and `fee_ppm` (u32 num) to the RPC `listpeers` output. Changelog-Added: fee_base and fee_ppm to listpeers
956a769
to
54af4c9
Compare
@rustyrussel I figured that in the current |
Note: Just checked, |
ACK 54af4c9 |
As mentioned in the last developer meeting and additional to #4221 we want to have the local half-channel fees (the ones that are applied when a payment is routed though our node) as part of the
listpeers
output. Motivation is that this data is non-gossip and currently only available via gossiplistchannels
.Example
This PR adds feature, test and doc.