pyln: add RPCException for finer method failure control. #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
pyln-plugin-exception
branch
from
63123cc
to
0274c75
Compare
😂 |
rustyrussell
force-pushed
the
pyln-plugin-exception
branch
from
0274c75
to
1296ac9
Compare
|
Renamed, no other changes. |
Allows caller to set code and exact message to be returned. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: pyln-client: plugins can now raise RpcException for finer control over error returns.
rustyrussell
force-pushed
the
pyln-plugin-exception
branch
from
1296ac9
to
85bd971
Compare
|
ACK 85bd971 |
darosior
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows caller to set code and exact message to be returned.
Signed-off-by: Rusty Russell rusty@rustcorp.com.au
Changelog-Added: pyln-client: plugins can now return RPCException for finer control over error returns.
THE BIG QUESTION: RPCException or RpcException?!? 😱