Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hsmtool: fix a segfault on dumponchaindescriptors default network parameter #4341

Merged
merged 1 commit into from
Jan 20, 2021
Merged

hsmtool: fix a segfault on dumponchaindescriptors default network parameter #4341

merged 1 commit into from
Jan 20, 2021

Conversation

darosior
Copy link
Collaborator

fixes #4339

@darosior
hsmtool: don't streq() on NULL
e08c1d4 
This would cause a segfault on the default network parameter for
`dumponchaindescriptors`.

Introduced in 1513a2d

Changelog-Fixed: hsmtool: fix a segfault on `dumponchaindescriptors` without network parameter
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
ZmnSCPxj
ZmnSCPxj approved these changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@ZmnSCPxj ZmnSCPxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e08c1d4

Let us let @cdecker decide whether to merge into 0.9.3 or defer to 0.9.4

@darosior
Copy link
Collaborator Author

Well that's a bugfix for 0.9.3 (happened with rc1).

@cdecker
Copy link
Member

cdecker commented Jan 20, 2021

Simple enough not to require an rc3, so I'll sneak it in :-)

Thanks @darosior for fixing this and @ZmnSCPxj for reviewing.

@cdecker cdecker merged commit 4859567 into ElementsProject:master Jan 20, 2021
@darosior darosior deleted the yes_i_know_ccan/opt_is_better branch April 3, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZmnSCPxj ZmnSCPxj ZmnSCPxj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rc1: hsmtool segfault
3 participants
@darosior @cdecker @ZmnSCPxj