Post v0.10 cleanups #4465
Merged
Post v0.10 cleanups #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change which affects us is that 2016 blocks to forget a channel is a fixed number in the spec; we make this clear by renaming the (developer-only) max_funding_unconfirmed to dev_max_funding_unconfirmed and making it compile DEVELOPER only. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/post-v0.10
branch
from
f0223db
to
570b015
Compare
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Instead of "only check suffix quotes when EXPERIMENTAL_FEATURES", make it so we only check suffix quotes if you override BOLTVERSION on the cmdline. Before this, "make check-source-bolt" was effectively a NOOP with --enable-experimental-features. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/post-v0.10
branch
from
570b015
to
20a1e9f
Compare
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: JSON-RPC: `close` now always returns notifications on delays.
rustyrussell
force-pushed
the
guilt/post-v0.10
branch
from
20a1e9f
to
a99513f
Compare
niftynei
approved these changes
Apr 7, 2021
| @@ -651,7 +623,6 @@ def dev_pay(self, bolt11, msatoshi=None, label=None, riskfactor=None, | |||
| "maxdelay": maxdelay, | |||
| "exemptfee": exemptfee, | |||
| "use_shadow": use_shadow, | |||
| # Deprecated. | |||
There was a problem hiding this comment.
nit, this isn't related to the other stuff changes, should be part of the next patch?
| @@ -151,9 +151,6 @@ static struct command_result *json_newaddr(struct command *cmd, | |||
| } | |||
|
|
|||
| response = json_stream_success(cmd); | |||
| if (deprecated_apis && *addrtype != ADDR_ALL) | |||
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: pyln: removed deprecated close `force` variant.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: pyln: removed deprecated pay/sendpay `description` arg.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: pyln: removed deprecated fundchannel/fundchannel_start `satoshi` arg.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: plugins: we now always send `allow-deprecated-apis` in getmanifest.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: JSON-RPC: `newaddr` no longer includes `address` field (deprecated in 0.7.1)
Should have really let @mschmook do this, as he did all the work to make it possible! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/post-v0.10
branch
from
a99513f
to
d36565f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time I greped for
deprecated...