Pay: handle when we're close to htlc limit #4563
Merged
+65
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
changed the title
cdecker
force-pushed
the
pay-calc-htlc-limit-properly
branch
2 times, most recently
from
f1c23a2
to
14c0877
Compare
|
Added one last fix that makes sure we don't exhaust the HTLC budget outright with the pre-splitter, leaving us some wiggle room to adapt to failures. @rustyrussell, can you review this despite being the opener? :D |
As you can see, I did a lot of debugging before realizing that the actual problem is in the pay plugin :( Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This was triggered by having some part being started after the overall command already gave up, cleaning up the `cmd` context from which the routehints were allocated. The early exit of the command, as a result from a terminal state does not guarantee that no later attempt will try to find a route, especially if the attempt was started before we knew that it is doomed.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We were counting the attempts including the root payment, which resulted in an off-by-one error with the `test_pay_low_max_htlcs` test. Counting the children of the root payment after the presplitter had a go is the correct way to do it, since at that time we only have one level in the tree, no need to recurse and potentially count ourselves.
Changelog-Fixed: pay: The presplitter mod will no longer exhaust the HTLC budget.
rustyrussell
force-pushed
the
pay-calc-htlc-limit-properly
branch
from
14c0877
to
10e0e96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't fix the problem, broke pay :( Help @cdecker !