Required jsonrpc string propriety inside the JSON rpc method request.

[vincenzopalazzo]

I discovered that my java RPC wrapper has some missing requirements with the jsonrpc 2.0 protocol, and the unusual thing is that it is accepted inside c-lightning a quest without "jsonrpc":"2.0" and as specified in the specification protocol the string must be present inside the request.

• First run it is only for testing.

Signed-off-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com

[rustyrussell]

I know Spark used not to do this.

@shesek does it now?

[vincenzopalazzo]

Worried about breaking stuff with this change, I mean it is not a big deal this check from a not protocol view. However, I was thinking to have a deprecated period for this?

[shesek]

Spark uses the clightning-client library, which was forked from BHB's lightning-client, which apparently indeed does not include the jsonrpc field.

I fixed that just now in shesek/lightning-client-js@78e103b and released clightning-client v0.1.4 with the fix. The next releases of Spark and Lightning Charge will use that.

Worried about breaking stuff with this change, I mean it is not a big deal this check from a not protocol view. However, I was thinking to have a deprecated period for this?

Agreed, I think there should be a deprecation period for this. I know that quite a few people still use old releases of Spark.

[vincenzopalazzo]

Added deprecated_apis checks, and added changelog fix and changelog deprecated fields in the last commit.

[rustyrussell]

Ack fe294dc

[rustyrussell]

Thanks everyone, this is great!