Give feedback notifications on closing negotiation when we use feerange #4784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/close-feedback
branch
2 times, most recently
from
2b53587
to
b365190
Compare
```
Global errors:
- Node /tmp/ltests-odpd7qtt/test_close_twice_1/lightning-1/ has memory leaks: [
{
"backtrace": [
"ccan/ccan/tal/tal.c:442 (tal_alloc_)",
"ccan/ccan/tal/tal.c:471 (tal_alloc_arr_)",
"lightningd/peer_control.c:1673 (param_feerate_range)",
"common/param.c:43 (make_callback)",
"common/param.c:140 (parse_by_name)",
"common/param.c:259 (param_arr)",
"common/param.c:344 (param)",
"lightningd/peer_control.c:1706 (json_close)",
"lightningd/jsonrpc.c:643 (command_exec)",
"lightningd/jsonrpc.c:778 (rpc_command_hook_final)",
"lightningd/plugin_hook.c:280 (plugin_hook_call_)",
"lightningd/jsonrpc.c:866 (plugin_hook_call_rpc_command)",
"lightningd/jsonrpc.c:965 (parse_request)",
"lightningd/jsonrpc.c:1056 (read_json)",
"ccan/ccan/io/io.c:59 (next_plan)",
"ccan/ccan/io/io.c:407 (do_plan)",
"ccan/ccan/io/io.c:417 (io_ready)",
"ccan/ccan/io/poll.c:445 (io_loop)",
"lightningd/io_loop_with_timers.c:24 (io_loop_with_timers)",
"lightningd/lightningd.c:1123 (main)"
],
"label": "lightningd/peer_control.c:1673:u32[]",
"parents": [
"lightningd/channel.c:372:struct channel"
],
"value": "0x56428b886208"
}
]
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… feerate!). Noted by @t-bast, this is how it should work, and this tests that it does. See also: ElementsProject#4777 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/close-feedback
branch
from
b365190
to
2655e16
Compare
|
ACK 2655e16 |
They share some code, but not much: command_find_channel is made non-static. Rest is move-only. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This allows cmdline users to have more idea what's going on. Inspired-by: ElementsProject#4777 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: `close` now notifies about the feeranges each side uses.
rustyrussell
force-pushed
the
guilt/close-feedback
branch
from
2655e16
to
20dbce5
Compare
|
Rebased to fix generated merge conflicts. Ack 20dbce5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will get more useful as more of the network upgrades.