Update offers to latest spec #4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, they are allowed to include .c files!
Here's `make check-units` on a maintainer-clean tree:
```
onchaind/test/run-onchainstress.c:4:10: fatal error: ../../hsmd/hsmd_wiregen.c: No such file or directory
4 | #include "../../hsmd/hsmd_wiregen.c"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:276: onchaind/test/run-onchainstress.o] Error 1
make: *** Waiting for unfinished jobs....
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
The latest ones use lno, not lni (this unit tests loads from ../lightning-rfc, silently exiting if it doesn't have the test vector). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
That's the modern BOLT12 term. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Main changes are: 1. Uses point32 instead of pubkey32. 2. Uses issuer instead of vendor. 3. Uses byte instead of u8. 4. blinded_path num_hops is now a byte, not u16 (we don't use that yet!). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-EXPERIMENTAL: bolt12: `vendor` is deprecated: the field is now called `issuer`.
rustyrussell
force-pushed
the
guilt/offers-latest-spec
branch
from
8cbaac7
to
f748f62
Compare
We keep the now-removed chains field, and in deprecated mode, we set it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-EXPERIMENTAL: bolt12: `chains` in invoice_request and invoice is deprecated, `chain` is used instead.
rustyrussell
force-pushed
the
guilt/offers-latest-spec
branch
from
f748f62
to
faa2a87
Compare
|
ACK faa2a87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only change of significance is the change of
chainstochainin invoices and invoice_requests. That's papered over for now with compatibility code.