coin_movement updates
#5019
Merged
coin_movement updates
#5019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a coin move concerns an external account, it's really useful to know which 'internal' account initiated the transfer. We're about to add a notification for withdrawals, so we can use this to track wallet pushes to outside addresses Changelog-Added: JSONRPC: `coin_movement` to 'external' accounts now include an 'originating_account' field
Requested in a comment on a previous PR
Report how much the deposit was for.
The blockheight is zero though, since these aren't included in a block yet. We also don't issue an 'external' deposit event if we can tell that the address you're sending to actually belongs to our wallet (we'll issue a deposit event when it gets included in a block)
niftynei
force-pushed
the
nifty/coin_moves_tweaks
branch
from
7e37932
to
050f377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the accounting plugin, I ran into some problems/limitations of our current event emissions.
We weren't tracking withdrawals to external wallets (initiated via
withdraw/multiwithdraw). This makes it really difficult to see where our funds are going, as well as confuses the onchain fee tracker that the accountant plugin has. Now, we emit acoin_movementforFunds sent to 'external' accounts don't say which account they originated from. While it's possible to figure this out from the utxo tracking, that's sometimes difficult to reconstruct. Instead, for every
externaldeposit, we now record what internal account the payment originated from. For example, wallet payments to an external account will be tagged 'wallet'. Payments to the peer in a channel will 'originate' from the channel's account.