More coin_move adjustments #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/acct_more_adj
branch
2 times, most recently
from
d3626ce
to
9de4c5e
Compare
We don't need to switch on this; if it's zero the below ops will be effectiely no-ops.
Every event that's coming out of here that specifies a different place to be deposited should be marked as originating from this channel's account.
The bookkeeper needs to know how many outputs to expect before we can consider a channel resolved onchain.
Only shows up on delayed to us outputs, but nice to have anyway. It's missing for channel index destined deposits, maybe nice to add at some point in the future; right now you can figure out which close a wallet deposit comes from via the channel close txid
Reporting coin movements was crashing for liquid-regtest tests because we were using an un-initialized field (the tx_part output's satoshi field). We fill this in 'as a convenience' for other wally_tx_outputs that are on liquid elsewhere, here we do the same for tx_parts sent over the wire to onchaind.
It's better to report every single utxo on close so we know when to mark a channel account as definitively closed.
Useful for accounting for missed/historical channel opens, to figure out what the actual sat contribution from each peer is at a utxo level Changelog-Added: JSONRPC: `listpeers` now includes a `pushed_msat` value. For leased channels, is the total lease_fee.
channel moves don't have blockheights
This was causing journal_entries to show up in the accountant plugin, since we don't emit events for unconfirmed events until they're actually confirmed onchain.
niftynei
force-pushed
the
nifty/acct_more_adj
branch
from
ba1d9aa
to
995b3df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more things fell out in the wash, so to speak, while working on the upcoming
bookkeeperplugin.