-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gossipd: use remote addr #5052
Merged
rustyrussell
merged 10 commits into
ElementsProject:master
from
m-schmoock:gossip/use_remote_addr
Mar 11, 2022
Merged
gossipd: use remote addr #5052
rustyrussell
merged 10 commits into
ElementsProject:master
from
m-schmoock:gossip/use_remote_addr
Mar 11, 2022
Commits on Mar 8, 2022
-
chore: fix typo announcable -> announceable
"announcable" is a common misspelling of "announceable", see: https://en.wiktionary.org/wiki/announcable
Configuration menu - View commit details
-
Copy full SHA for 3c4a522 - Browse repository at this point
Copy the full SHA 3c4a522View commit details -
Configuration menu - View commit details
-
Copy full SHA for b23a97f - Browse repository at this point
Copy the full SHA b23a97fView commit details -
connectd: ignore private remote_addr on non-DEVELOPER builds
When compiled without DEVELOPER this will now filter out `remote_addr` that come from localhost. The testcase checks for DEVELOPER to test for correct function of `remote_addr`. Also, I renamed "test_connect" to "test_connect_basic" so it can be started without all the other tests in that file that start with "test_connect..."
Configuration menu - View commit details
-
Copy full SHA for bcdc171 - Browse repository at this point
Copy the full SHA bcdc171View commit details -
wireaddr: adds wireaddr_eq_without_port and wireaddr_cmp_type
Adds wireaddr_eq_without_port so it can be used later. Moves wireaddr_cmp_type from connectd.c to this file, so it can be reused later.
Configuration menu - View commit details
-
Copy full SHA for 18565d6 - Browse repository at this point
Copy the full SHA 18565d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bcfeae - Browse repository at this point
Copy the full SHA 5bcfeaeView commit details -
gossipd: send updated node_annoucement remote_addr
This is the cheapest algo I came up with that simply checks that the same `remote_addr` has been report by two different peers. Can be improved in many ways: - Check by connecting to a radonm peers in the network - Check for more than two confirmations or a certain fraction - ... Changelog-Added: Send updated node_annoucement when two peers report the same remote_addr.
Configuration menu - View commit details
-
Copy full SHA for 04a05db - Browse repository at this point
Copy the full SHA 04a05dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fd4c99 - Browse repository at this point
Copy the full SHA 1fd4c99View commit details -
Increases test coverage by adding a testcase for connectd/netaddress.c Changelog-None
Configuration menu - View commit details
-
Copy full SHA for 4dff537 - Browse repository at this point
Copy the full SHA 4dff537View commit details
Commits on Mar 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a7d7b2f - Browse repository at this point
Copy the full SHA a7d7b2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for dda19f5 - Browse repository at this point
Copy the full SHA dda19f5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.