Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gossipd: use remote addr #5052

Merged
merged 10 commits into from
Mar 11, 2022

Commits on Mar 8, 2022

  1. chore: fix typo announcable -> announceable

    "announcable" is a common misspelling of "announceable", see:
    
    https://en.wiktionary.org/wiki/announcable
    m-schmoock committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    3c4a522 View commit details
    Browse the repository at this point in the history
  2. pyln-proto: fix port typo in example script

    Changelog-None
    m-schmoock committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    b23a97f View commit details
    Browse the repository at this point in the history
  3. connectd: ignore private remote_addr on non-DEVELOPER builds

    When compiled without DEVELOPER this will now filter out `remote_addr` that
    come from localhost. The testcase checks for DEVELOPER to test for correct
    function of `remote_addr`.
    
    Also, I renamed "test_connect" to "test_connect_basic" so it can be started
    without all the other tests in that file that start with "test_connect..."
    m-schmoock committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    bcdc171 View commit details
    Browse the repository at this point in the history
  4. wireaddr: adds wireaddr_eq_without_port and wireaddr_cmp_type

    Adds wireaddr_eq_without_port so it can be used later.
    Moves wireaddr_cmp_type from connectd.c to this file, so it can be reused later.
    m-schmoock committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    18565d6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5bcfeae View commit details
    Browse the repository at this point in the history
  6. gossipd: send updated node_annoucement remote_addr

    This is the cheapest algo I came up with that simply checks that the
    same `remote_addr` has been report by two different peers. Can be
    improved in many ways:
    
     - Check by connecting to a radonm peers in the network
     - Check for more than two confirmations or a certain fraction
     - ...
    
    Changelog-Added: Send updated node_annoucement when two peers report the same remote_addr.
    m-schmoock committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    04a05db View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1fd4c99 View commit details
    Browse the repository at this point in the history
  8. test: connectd netaddress

    Increases test coverage by adding a testcase for connectd/netaddress.c
    
    Changelog-None
    m-schmoock committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    4dff537 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Configuration menu
    Copy the full SHA
    a7d7b2f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dda19f5 View commit details
    Browse the repository at this point in the history