Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools: Add fund_nodes command to startup_regtest.sh #5062

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

ddustin
Copy link
Collaborator

@ddustin ddustin commented Mar 2, 2022

Also fix an occasional quirk of bitcoin-cli where you have to call loadwallet

ddustin referenced this pull request in ddustin/lightning Mar 2, 2022
fund_ln connects the two peers and funds a channel between them.
@niftynei
Copy link
Collaborator

Test fails are coming from make check-shellcheck fyi!

Those errors need fixing, otherwise lgtm. Also added a few tweaks. Thanks!

Copy link
Collaborator

@niftynei niftynei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cd34680

Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but perhaps just add a fund_nodes instead (perhaps with --wallet=?)

And squash into a single commit :)

contrib/startup_regtest.sh Outdated Show resolved Hide resolved
contrib/startup_regtest.sh Outdated Show resolved Hide resolved
contrib/startup_regtest.sh Outdated Show resolved Hide resolved
contrib/startup_regtest.sh Outdated Show resolved Hide resolved
contrib/startup_regtest.sh Show resolved Hide resolved
contrib/startup_regtest.sh Outdated Show resolved Hide resolved
@ddustin ddustin force-pushed the ddustin/fund_ln branch 2 times, most recently from 7e24f90 to 26f30c6 Compare May 26, 2022 00:29
fund_ln connects the two peers and funds a channel between them.

Changelog-Added: Added fund_ln to the contrib/startup_regtest.sh
@ddustin ddustin changed the title devtools: Add fund_ln command to startup_regtest.sh devtools: Add fund_nodes command to startup_regtest.sh May 26, 2022
@ddustin
Copy link
Collaborator Author

ddustin commented May 26, 2022

Nice, but perhaps just add a fund_nodes instead (perhaps with --wallet=?)

And squash into a single commit :)

Okay I believe I got all the changes in and also cleaned things up. Should work for 100 nodes now =)

@rustyrussell
Copy link
Contributor

Ack 51ee61d

@rustyrussell rustyrussell merged commit aac22f3 into ElementsProject:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants