Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnprototest: upgrade the lnprototest version #5082

Conversation

vincenzopalazzo
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo commented Mar 10, 2022

Working today on c-lightning I noted some CI errors related to the lnprototest like this one or described in this issue rustyrussell/lnprototest#31

I'm not sure that this will fix the error but it will introduce some change on how lnprototest manages the bitcoin backend, so I think it would be useful given a try.

P.S: Hoping to improve in the near future the upgrade process of lnprototest in the CI

Signed-off-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com

@vincenzopalazzo vincenzopalazzo force-pushed the vincenzopalazzo/lnprototest_version branch 2 times, most recently from 08ffdec to 16bea29 Compare March 11, 2022 09:42
@vincenzopalazzo
Copy link
Collaborator Author

For some reason, we have the CI stack on the protocol test, but on the lnprototest repo, the integration testing takes only 12m 19s https://github.com/rustyrussell/lnprototest/runs/5477872454?check_suite_focus=true

@rustyrussell
Copy link
Contributor

@cdecker Seems to clash with the change to poetry?

@vincenzopalazzo vincenzopalazzo force-pushed the vincenzopalazzo/lnprototest_version branch from 16bea29 to 7a57d11 Compare March 15, 2022 08:52
@vincenzopalazzo
Copy link
Collaborator Author

Seems to clash with the change to poetry?

Mh! Seems more a problem related to test execution, in particular, related to the "send and receive" messages event.

With the actual fix on lnprototest rustyrussell/lnprototest#38 we are a little bit slow (2 min) because now we manage correctly the backend and the restart process of all the lnprototest conf and restart it.

So, I will try to give another run to the CI with a rebase and see if I can catch the bug (if I introduce some things) in lnprototest, I don't think that it is related to this repo and to the poetry introduction

Changelog-None: upgrade the lnprototest version

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo vincenzopalazzo force-pushed the vincenzopalazzo/lnprototest_version branch from 7a57d11 to 0070902 Compare March 15, 2022 16:49
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 0070902

@rustyrussell rustyrussell merged commit 8b04bf1 into ElementsProject:master Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants