lightningd: allow 'style' 'legacy' for clboss compat (with deprecated_apis) #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
suggested changes
Mar 23, 2022
We already documented that we removed legacy, but you're right. |
…_apis). We keep the parameter around for future use (e.g. PTLC support?), but clboss master still sets 'style' to "legacy". Accept, but ignore it. Reported-by: grubman on #c-lightning (IRC) Changelog-Deprecated: JSON-RPC: `sendpay` `route` argument `style` "legacy" (don't use it at all, we ignore it now and always use "tlv" anyway). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Well, it is leaking a bool for the command duration, but that's probably OK. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
fix-clboss
branch
from
093920d to
c4f84a1
Compare
I put on my to-do list that may be necessary to remove this remove legacy line in the Changelog generation. |
|
ACK c4f84a1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep the parameter around for future use (e.g. PTLC support?), but clboss
master still sets 'style' to "legacy". Accept, but ignore it.
Reported-by: grubman on #c-lightning (IRC)
Changelog-None: change introduced this release