Revenge of the legacy onion #5146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
added
the
protocol
rustyrussell
force-pushed
the
guilt/revenge-of-the-legacy-onion
branch
2 times, most recently
from
730bc9e
to
e188707
Compare
cdecker
approved these changes
Mar 30, 2022
|
tACK e188707 |
|
Included flake fix (unrelated) Ack 58f0ed1 |
rustyrussell
force-pushed
the
guilt/revenge-of-the-legacy-onion
branch
from
59cce61
to
c0f7880
Compare
We never called this except from plugins, which didn't test schema. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Using a canned sendonion call from an old version (v0.10.2), where I forced it to use legacy onion for l2. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Partial revert of 43a833e "lightningd: remove support for legacy onion format."; we restore the ability to decode legacy onions for forwarding, but not to generate them. (We don't accept them properly since making payment_secret compulsory anyway, so no real change there!) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: Protocol: ... but we still forward legacy HTLC onions for now.
Suggested-by: @t-bast Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: JSON-RPC: `listforwards` has new entry `style`, currently "legacy" or "tlv".
Gossipd didn't actually suppress all gossip, resulting in a flake! Doing it in connectd now makes much more sense. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/revenge-of-the-legacy-onion
branch
from
c0f7880
to
58f0ed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Too soon?"
"Too soon"
These are still happening on the network (and clboss was still sending them!), so a campaign has begun to warn people. Meanwhile we restore the minimal legacy we can (forwarding only).
Most of the time was coming up with a reliable test of the now-we-can't-generate legacy onions.