fix: dns announcement without port #5434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an X-Fail testcase that demonstrates that currently the port of a DNS announcement is not set to the corresponding network port (in this case regtest), but it will be set to 0. Changelog-None
- set port for a DNS announcement without port to network default - remove x-fail Changelog-Fixed: Port of a DNS announcement can be 0 if unspecified
|
Ack bea7865 |
cdecker
approved these changes
Jul 17, 2022
|
3 ACKs are enough :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently when we announce a DNS address without specifying the port, lightningd will announce it with port 0, which is invalid.
Affects
EXPERIMENTAL builds with DNS announcement
Solution
This will fix set it to the corresponding network port.