pyln-client: allow 'msat' fields to be 'null' #5574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens with deprecated-apis and listconfigs, breaking some python plugins! Fixes: ElementsProject#5546 Fixes: ElementsProject#5563 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added
the
Type::Bug
jonasnick
reviewed
Sep 6, 2022
Contributor
jonasnick
left a comment
jonasnick
left a comment
There was a problem hiding this comment.
This PR makes the nix-bitcoin test suite pass.
Without it, the test suite fails, because the summary and feeadjuster plugins crash on startup. The test suite is not very in-depth, it just checks that the plugins are loaded and that certain commands don't fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens with deprecated-apis and listconfigs, breaking some
python plugins!
Fixes: #5546
Fixes: #5563