Offers initial cleanups #5633
Merged
Offers initial cleanups #5633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
offers-initial-cleanups
branch
from
c20de2e
to
eb5841d
Compare
|
Trivial rebase on master now #5605 merged. |
rustyrussell
force-pushed
the
offers-initial-cleanups
branch
from
eb5841d
to
37456eb
Compare
cdecker
approved these changes
Sep 28, 2022
rustyrussell
force-pushed
the
offers-initial-cleanups
branch
from
37456eb
to
b039522
Compare
…store`) Changelog-Added: JSON-RPC: `makesecret` can take a string argument instead of hex. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This reveals that common/test/run-bolt12_merkle-json.c was broken! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Generate the payload in the callers. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This makes it easier to add/delete fields manually to a bolt12 encoding. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
If we do, an upgrade would mean we can no longer get refunds on old invoices. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
There's no secp256k1 routine to do this, but we're going to need it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It's been obsoleted and needs replacing; less confusing if we remove it first. Also, these fields are now present even without an expermintal build (we'll control at runtime). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We don't actually process onion messages here any more (they moved to connectd), but the flag and object files were still linked. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
offers-initial-cleanups
branch
from
b039522
to
b19fd13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5605- MergedThis just does some preparatory cleanups in preparation for the spec-compliant implementation of blinded payments and modern offers.