lightningd: do not abort while parsing hsm pwd #5725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
reviewed
Nov 21, 2022
vincenzopalazzo
force-pushed
the
macros/hsmd_password
branch
from
e3eaaf8
to
259585a
Compare
|
ACK 259585a |
There was a problem hiding this comment.
Just confirming that testing this, the change worked for me, thanks for taking a look at this @vincenzopalazzo
cdecker
force-pushed
the
macros/hsmd_password
branch
2 times, most recently
from
7e76e7d
to
3579b9d
Compare
This is a mistake that I introduced while I implemented the lightningd custom error for hsmd. In particular, when the command line parser check if the file is encrypted make an additional check regarding the existence of the file. This can be a not useful check, but due to the delicate nature of the hsm file, it is better to check if exist and if it doesn't exist an informative line inside the log is emitted that notifies the user that the file does not exist. This log may return useful while debugging disaster (that can happen) to understand that there is something strange (eg. the user moves the hsm file somewhere else). Fixes ElementsProject#5719 Changelog-Fixed: lightningd: do not abort while parsing hsm pwd Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
cdecker
force-pushed
the
macros/hsmd_password
branch
from
3579b9d
to
37b27b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mistake that I introduced while I implemented the lightningd custom error for hsmd.
In particular, when the command line parser check
if the file is encrypted make an additional check regarding the existence of the file.
This can be a not useful check, but due to the delicate nature of the hsm file, it is better to check if exist and if it doesn't exist an informative line inside the log is emitted that notifies the user that the file does not exist.
This log may return useful while debugging disaster
(that can happen) to understand that there is something strange (eg. the user moves the hsm file somewhere else).
Fixes #5719
Signed-off-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com