Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channeld: remove dead HTLCs from htable and free them (eventually) #5882

Merged
merged 1 commit into from
Jan 20, 2023
Merged

channeld: remove dead HTLCs from htable and free them (eventually) #5882

merged 1 commit into from
Jan 20, 2023

Commits on Jan 6, 2023

  1. channeld: remove dead HTLCs from htable and free them (eventually) 

    The channel->htlcs map was exhibiting unbounded growth, as elements were
never removed from it. This was causing lightning_channeld processes to
consume ever-increasing amounts of memory, and iterating over the map
was causing ever-increasing CPU utilization. There were FIXME comments
suggesting that the intention was to remove HTLCs from the map upon
their deaths. This commit implements that intention.

Changelog-Fixed: channeld no longer retains dead HTLCs in memory.
    @whitslack
    whitslack committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    5fa5ad0 View commit details
    Browse the repository at this point in the history