Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement conversions JSON->GRPC for requests type and GRPC->JSON for repsonses types #5890

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

RCasatta
Copy link
Contributor

@RCasatta RCasatta commented Jan 11, 2023

This could be useful for existing software with a JSON interface that wants to mimic the interface

Also, this enables tests to do roundtripping of the requests and response objects and check results are equal to initial value. Unfortunately this is not always the case at this stage and assert_eq!() on test_listpeers is commented out at the moment

Changelog-None

@RCasatta RCasatta changed the title Implement conversion JSON->GRPC also for requests type Implement conversions JSON->GRPC for requests type and GRPC->JSON for repsonses types Jan 13, 2023
@RCasatta RCasatta force-pushed the req_json_to_grpc branch 2 times, most recently from c16abe5 to b2cd36b Compare January 16, 2023 10:31
@RCasatta RCasatta force-pushed the req_json_to_grpc branch 2 times, most recently from 99a9dfd to bd25a36 Compare January 23, 2023 14:06
@RCasatta
Copy link
Contributor Author

Removing draft since CI is passing, however, it's probably better to go after #5907 and (#5904 or #5902) to have some successful roundtrips in tests

@RCasatta RCasatta marked this pull request as ready for review January 23, 2023 16:36
@vincenzopalazzo
Copy link
Collaborator

Removing draft since CI is passing, however, it's probably better to go after #5907 and (#5904 or #5902) to have some successful roundtrips in tests

Yeah, I rerun the CI so if will pass (if not is postgress flaky problem) we can ping somebody to get it merge before the rc1

@vincenzopalazzo vincenzopalazzo added this to the v23.02 milestone Jan 25, 2023
.gitattributes Outdated Show resolved Hide resolved
@RCasatta RCasatta force-pushed the req_json_to_grpc branch 2 times, most recently from 7a829a5 to 37bec26 Compare February 1, 2023 13:25
@RCasatta
Copy link
Contributor Author

RCasatta commented Feb 1, 2023

Rebased after #5907 and #5904 have been merged.
Now also test_getinfo roundtrips ok

@cdecker
Copy link
Member

cdecker commented Feb 8, 2023

ACK 37bec26

@cdecker
Copy link
Member

cdecker commented Feb 8, 2023

Rebased on top of master, let's see if it passes CI cleanly :-)

@cdecker
Copy link
Member

cdecker commented Feb 8, 2023

And another rebase and update, to pick up num_channels which was added on master

@endothermicdev
Copy link
Collaborator

ACK 0447795

@endothermicdev endothermicdev merged commit 510abb9 into ElementsProject:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants