-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement conversions JSON->GRPC for requests type and GRPC->JSON for repsonses types #5890
Merged
endothermicdev
merged 4 commits into
ElementsProject:master
from
RCasatta:req_json_to_grpc
Feb 8, 2023
Merged
Implement conversions JSON->GRPC for requests type and GRPC->JSON for repsonses types #5890
endothermicdev
merged 4 commits into
ElementsProject:master
from
RCasatta:req_json_to_grpc
Feb 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCasatta
force-pushed
the
req_json_to_grpc
branch
from
January 11, 2023 14:26
b136864
to
4d3ecf1
Compare
RCasatta
changed the title
Implement conversion JSON->GRPC also for requests type
Implement conversions JSON->GRPC for requests type and GRPC->JSON for repsonses types
Jan 13, 2023
RCasatta
force-pushed
the
req_json_to_grpc
branch
2 times, most recently
from
January 16, 2023 10:31
c16abe5
to
b2cd36b
Compare
RCasatta
force-pushed
the
req_json_to_grpc
branch
2 times, most recently
from
January 23, 2023 14:06
99a9dfd
to
bd25a36
Compare
cdecker
reviewed
Jan 26, 2023
cdecker
reviewed
Jan 26, 2023
RCasatta
force-pushed
the
req_json_to_grpc
branch
2 times, most recently
from
February 1, 2023 13:25
7a829a5
to
37bec26
Compare
ACK 37bec26 |
This could be useful for existing software with a JSON interface that want to mimic the interface
cdecker
force-pushed
the
req_json_to_grpc
branch
from
February 8, 2023 16:01
37bec26
to
5989896
Compare
Rebased on top of |
cdecker
force-pushed
the
req_json_to_grpc
branch
from
February 8, 2023 16:33
5989896
to
0447795
Compare
And another rebase and update, to pick up |
ACK 0447795 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be useful for existing software with a JSON interface that wants to mimic the interface
Also, this enables tests to do roundtripping of the requests and response objects and check results are equal to initial value. Unfortunately this is not always the case at this stage and
assert_eq!()
ontest_listpeers
is commented out at the momentChangelog-None