lightningd: don't print zero blockheight while we're syncing. #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v0.11 (71f7366) we changed lightningd to wait for gossipd to acknowledge blocks before updating blockheight: this resolved a problem which lnprototest had where it wanted to know when we'd fully digested a block. However, it broke the syncing case: until then we don't even tell gossipd, so this stayed at zero. We should use the current blockheight for that corner case! Fixes: ElementsProject#5894 Changelog-Fixed: JSON-RPC: `getinfo` `blockheight` no longer sits on 0 while we sync with bitcoind the first time. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v0.11 (71f7366) we changed lightningd to wait for gossipd to acknowledge blocks before updating blockheight: this resolved a problem which lnprototest had where it wanted to know when we'd fully digested a block.
However, it broke the syncing case: until then we don't even tell gossipd, so this stayed at zero. We should use the current blockheight for that corner case!
Fixes: #5894
Changelog-Fixed: JSON-RPC:
getinfoblockheightno longer sits on 0 while we sync with bitcoind the first time.Signed-off-by: Rusty Russell rusty@rustcorp.com.au