Removals for v23.05 (deprecated in 0.12.0 or before) #5986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
changed the title
rustyrussell
force-pushed
the
guilt/deprecations-for-v23.05
branch
from
ce987bd
to
ab87eff
Compare
rustyrussell
changed the title
rustyrussell
force-pushed
the
guilt/deprecations-for-v23.05
branch
2 times, most recently
from
f1eb567
to
c998659
Compare
Makes it easier when we remove support for a version. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We promised two versions after v0.12, and here we are. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…quietly. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: JSON-RPC: `checkmessage` now always returns an error when the pubkey is not specified and it is unknown in the network graph (deprecated v0.12.0)
Changelog-Removed: JSON-RPC: `listpeers`.`local_msat` and `listpeers`.`remote_msat` (deprecated v0.12.0) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: JSON-RPC: all the non-msat-named millisatoshi fields deprecated in v0.12.0.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: JSON-RPC: the "msat" suffix on millisatoshi fields, as deprecated in v0.12.0.
Now there's no compat variant, we can rename this function. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: JSON-RPC: require the `"jsonrpc": "2.0"` property (requests without this deprecated in v0.10.2).
It seems that bitcoind frequently dies on this test. I assume running the multiple nodes under valgrind with the extra 214 blocks is too memory-hungry? Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/deprecations-for-v23.05
branch
from
aa5abdd
to
5b7b86b
Compare
|
Trivial rebase onto latest master. |
vincenzopalazzo
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
I am running with deprecated-api=false for more than 3 months now!
ACK 5b7b86b
| @@ -286,7 +286,6 @@ On success, an object containing **route** is returned. It is an array of objec | |||
| - **amount\_msat** (msat): The amount expected by the node at the end of this hop | |||
| - **delay** (u32): The total CLTV expected by the node at the end of this hop | |||
| - **style** (string): The features understood by the destination node (always "tlv") | |||
| - **msatoshi** (u64, optional) **deprecated, removal in v23.05** | |||
There was a problem hiding this comment.
from a doc point of view, do you think that it is better remove from the docs when it is already released? so in the v23.08 in this case
I think this could add a little bit of more documentation when people find this breaking change
There was a problem hiding this comment.
Hmm... that's a bit trickier, we'd have to add a "removed": "version" tag in the schema. Probably not worth it for now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importantly, this completes the Great Msat Migration started in v0.12.0, so "msat" fields are no longer strings with
"msat" appended, but simply integers.
And we re-try deprecating non-jsonrpc-2.0 compliant requests.