chanbackup: even if they enable experimental-peer-storage, check peers #6072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like LND is hanging up on receiving these messages, even though they're odd :( So, when a peer connects, check if it supplies or wants peer backup (even if it doesn't support both, it shouldn't hang up, and I didn't want to separate the two paths). And when we go to send our own, updated backup, check features before sending. Fixes: ElementsProject#6065 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-EXPERIMENTAL: `experimental-peer-storage` caused LND to hang up on us, so only send to peers which support it.
| @@ -436,17 +436,30 @@ static struct command_result *after_listpeers(struct command *cmd, | |||
| bool is_connected; | |||
| u8 *serialise_scb; | |||
|
|
|||
| if (!peer_backup) | |||
| return notification_handled(cmd); | |||
There was a problem hiding this comment.
Is there a reason to short circuit here rather than in after_staticbackup?
There was a problem hiding this comment.
I was aiming for minimal changes. but I pulled this out of the loop. I think you're right, the check could be done earlier..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like LND is hanging up on receiving these messages, even though they're odd :(
So, when a peer connects, check if it supplies or wants peer backup (even if it doesn't support both, it shouldn't hang up, and I didn't want to separate the two paths).
And when we go to send our own, updated backup, check features before sending.
Fixes: #6065
Changelog-EXPERIMENTAL:
experimental-peer-storagecaused LND to hang up on us, so only send to peers which support it.