grpc: Adjust the file permissions on mTLS private keys #6075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
changed the title
cdecker
force-pushed
the
202303-cln-grpc-cert-mode
branch
2 times, most recently
from
0f638c5
to
c991cee
Compare
Fixes ElementsProject#6064 Reported-by: denis2342 <@denis2342> Changelog-Changed: grpc: The mTLS private keys are no longer group-readable
We should rather hand the annotation through to the user code, and warn there.
cdecker
force-pushed
the
202303-cln-grpc-cert-mode
branch
from
c991cee
to
60bace3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mTLS private key files should be user-readable only, so set the mode accordingly. Also contains a bit of a drive-by fix for deprecated fields in our own code, causing warnings.
Fixes #6064