Recover mode for recovering using codex32 secret string. #6302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
requested changes
Jun 3, 2023
|
Thank you for the review @rustyrussell! I've added the suggested changes. |
adi2011
force-pushed
the
RecoverCodex32
branch
2 times, most recently
from
cb9eeeb
to
9ce36d8
Compare
adi2011
force-pushed
the
RecoverCodex32
branch
4 times, most recently
from
202760f
to
881a440
Compare
|
Try |
rustyrussell
requested changes
Jul 12, 2023
adi2011
force-pushed
the
RecoverCodex32
branch
2 times, most recently
from
f2a0350
to
0e4d08f
Compare
common/codex32.c
Outdated
Comment on lines
147
to
148
| input_hrp((&codex_checksum_engine)->generator, (&codex_checksum_engine)->residue ,hrp, len); | ||
| input_data_str((&codex_checksum_engine)->generator, (&codex_checksum_engine)->residue, codex_datastr, len); |
There was a problem hiding this comment.
No need for &(...), just &engine?
There was a problem hiding this comment.
Here engine is not a pointer. So it throws invalid type argument of ‘->’ (have ‘struct checksum_engine’). If I don't use &(...)
There was a problem hiding this comment.
Ah, engine.generator then!
adi2011
force-pushed
the
RecoverCodex32
branch
11 times, most recently
from
36d4c71
to
7607744
Compare
|
Ok, tomorrow I'm going to clean this up so it bisects and then apply. @adi2011 had promised to implement the hsmtool code to give you the code for your hsm_secret so this is useful! |
…ppropriate secret through a valid codex32 secret.
Nothing major here: 1. size_t for lengths. 2. pass engine to checksum_verify, as caller wants ->len (avoid repeating 13/15 magic numbers). 3. Use x.member instesad of (&x)->member. 4. Return memcmp result directly instead of if. 5. Spacing removal, `;;` removal. 6. codexl is a bool `true`/`false` not 0/1 (it's the same, but clearer) 7. Make sanity_check assign *fail directly. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
RecoverCodex32
branch
from
e7c1194
to
c6507a8
Compare
Firstly, I wanted the results easier to use: 1. Make them always lower case, even if the string was UPPER. 2. Decode the payload for them. 3. Don't give the user any fields they don't need, and make the field sizes explicit. Secondly, I wanted to avoid the pattern of "check in one place, assume in another", in favour of "check on use". So, I changed the code to lower the string if it needs to at the start, and then changed the pull functions so we always use them to get data: this way we should fail clearly and gracefully if we don't have enough data. I made all the checks explicit, where we assign the fields. I also addressed the FIXME: I think the array is *often* one shorter, but not always, so I trim the last byte at the end if needed. [ Aditya modified the tests to work ] Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
RecoverCodex32
branch
from
c6507a8
to
40701a0
Compare
|
One trivial whitespace fix, merged the test fixup with my cleanup, and removed final commit. Ack 40701a0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would enable users to recover their node using codex32 secret (bip-0093) if their HSM secret file doesn't exist.
bip-0093: https://github.com/bitcoin/bips/blob/master/bip-0093.mediawiki