Don't gossip about recently-closed channels #6413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We don't actually delete them for 12 blocks, but we can't avoid propagating them. We don't mark node_announcements, which is a bit weird, but avoids us tracking logic to un-dying them if a channel is opened. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: ElementsProject#6368 Changelog-Fixed: Protocol: we no longer gossip about recently-closed channels (Eclair gets upset with this). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
endothermicdev
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Looks nice. I think the unit test updates should fall out in the rebase.
The spec doesn't say anything about not gossiping dying channels. Is this a temporary accommodation for Eclair, or should we discuss clarifying the spec on this?
ACK 00b8bc9
| /* Mark it dying, so we don't gossip it */ | ||
| gossip_store_mark_dying(rstate->gs, &chan->bcast, | ||
| WIRE_CHANNEL_ANNOUNCEMENT); | ||
| for (int dir = 0; dir < ARRAY_SIZE(chan->half); dir++) { |
There was a problem hiding this comment.
Is ARRAY_SIZE(chan->half) generally preferred over 2? (Just so I can stay consistent)
There was a problem hiding this comment.
Since we're explicitly iterating over the chan->half array, ARRAY_SIZE makes sense here?
| /* Should never try to overwrite version */ | ||
| assert(bcast->index); | ||
|
|
||
| /* Sanity check, that this is a channel announcement */ |
There was a problem hiding this comment.
...or update, as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.