Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightningd: use CPFP on peer's commitment tx if we can't broadcast our own #6752

Merged
merged 8 commits into from
Oct 27, 2023
Merged

lightningd: use CPFP on peer's commitment tx if we can't broadcast our own #6752

merged 8 commits into from
Oct 27, 2023

Commits on Oct 26, 2023

  1. pytest: test (fails!) that we push anchor on peer's commitment tx. 

    We try to use anchors to CPFP our own commitment, but what if they
get there first?  We also need to use anchors on the commitment
txs they broadcast.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @nepet
    rustyrussell authored and nepet committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6693d23 View commit details
    Browse the repository at this point in the history

  2. channeld: get rid of unused commit_sig and htlc_sigs in channeld_send… 

    …ing_commitsig

We don't actually use this at all.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @nepet
    rustyrussell authored and nepet committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    2544068 View commit details
    Browse the repository at this point in the history

  3. channeld: rename channel_splice_txs to channel_txs. 

    channel_txs was a thin wrapper around channel_splice_txs, but that's
just confusing.  Rename channel_splice_txs to channel_txs, and just
call it everywhere.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @nepet
    rustyrussell authored and nepet committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    0229359 View commit details
    Browse the repository at this point in the history

  4. channeld: have commit_tx tell is what output was the other's anchor. 

    We're going to want this, soon.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @nepet
    rustyrussell authored and nepet committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    061f680 View commit details
    Browse the repository at this point in the history

  5. channeld: tell lightningd about local anchor for each commitment tx. 

    It's going to want to remember these, in case it encounters peers'
commitment tx and needs to boost it with CPFP on the anchor.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @nepet
    rustyrussell authored and nepet committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    e4fd6af View commit details
    Browse the repository at this point in the history

  6. lightningd: routines to deal with peer commitment anchor info in db. 

    Store enough to know how to CPFP the peer's commitment tx.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @nepet
    rustyrussell authored and nepet committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    03560ca View commit details
    Browse the repository at this point in the history

  7. lightningd: save peer's commitment anchor info into db. 

    We actually only need to remember the last two, worst case.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @nepet
    rustyrussell authored and nepet committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    b9fab74 View commit details
    Browse the repository at this point in the history

  8. channeld: use anchors on peer's commitment(s) if we can't broadcast o… 

    …ur own.

This means refactoring out some of the generic anchor info, from the
per-commitment-tx info (we can have at least two, perhaps more with
splicing!).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @nepet
    rustyrussell authored and nepet committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d3d6e5b View commit details
    Browse the repository at this point in the history