Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offers deprecate string recurrence #7034

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Offers deprecate string recurrence #7034

merged 2 commits into from
Feb 6, 2024

Commits on Feb 3, 2024

  1. common: don't insist on unique param() arguments. 

    It can actually be useful for more complex parameter parsing, as we're about to see.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    04e140a View commit details
    Browse the repository at this point in the history

  2. lightningd: deprecate @-prefix hack for offer recurrence_base. 

    Christian points out that this makes the type harder, and it's just awkward.

Changelog-EXPERIMENTAL: JSON-RPC: Deprecated `offer` parameter `recurrence_base` with `@` prefix: use `recurrence_start_any_period`.
Changelog-EXPERIMENTAL: JSON-RPC: Added `offer` parameter `recurrence_start_any_period`.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    9d7055d View commit details
    Browse the repository at this point in the history