-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster startup #7175
Merged
vincenzopalazzo
merged 8 commits into
ElementsProject:master
from
rustyrussell:guilt/faster-startup
Apr 1, 2024
Merged
Faster startup #7175
vincenzopalazzo
merged 8 commits into
ElementsProject:master
from
rustyrussell:guilt/faster-startup
Apr 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pay. This is useful once we allow pay before full sync. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/faster-startup
branch
2 times, most recently
from
March 26, 2024 06:09
42780c3
to
8b1c29b
Compare
Woops! There was already a test for this, I didn't need a new one. Will repurpose that instead! |
This allows for faster startup for Greenlight. We still require full sync before *incoming* htlcs, and onchain operations. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
For testing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/faster-startup
branch
2 times, most recently
from
March 27, 2024 05:49
f5257ed
to
57792e0
Compare
I was trying to debug test_zeroconf_open and getting very confused. The reason: l0 is lightning-1, l1 is lightning-2, etc! And there are two other tests where an l0 has been added at the front: fix them all to avoid future confusion! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…roconf. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: JSON-RPC: `fundchannel_start` now disallows a non-zero `mindepth` parameter if you ask for a zeroconf `channel_type`.
rustyrussell
force-pushed
the
guilt/faster-startup
branch
from
March 28, 2024 01:17
57792e0
to
c155e42
Compare
vincenzopalazzo
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c155e42
Really nice idea!
cdecker
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require us to be fully synced with bitcoind before we allow certain operations:
This means Greenlight doesn't have to block operations while waiting for block sync.