Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster startup #7175

Merged

Conversation

rustyrussell
Copy link
Contributor

Don't require us to be fully synced with bitcoind before we allow certain operations:

  1. Allow outgoing HTLCs immediately.
  2. Wait for openchannel_init/openchannel_bump/fundchannel_start instead of failing.
  3. Use bitcoind's height, not ours, for CLTV values on payments.

This means Greenlight doesn't have to block operations while waiting for block sync.

@rustyrussell rustyrussell added this to the v24.05 milestone Mar 26, 2024
…pay.

This is useful once we allow pay before full sync.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell force-pushed the guilt/faster-startup branch 2 times, most recently from 42780c3 to 8b1c29b Compare March 26, 2024 06:09
@rustyrussell
Copy link
Contributor Author

Woops! There was already a test for this, I didn't need a new one. Will repurpose that instead!

This allows for faster startup for Greenlight.  We still require full sync
before *incoming* htlcs, and onchain operations.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
For testing.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell force-pushed the guilt/faster-startup branch 2 times, most recently from f5257ed to 57792e0 Compare March 27, 2024 05:49
I was trying to debug test_zeroconf_open and getting very confused.
The reason: l0 is lightning-1, l1 is lightning-2, etc!  And there are
two other tests where an l0 has been added at the front: fix them all
to avoid future confusion!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…roconf.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: JSON-RPC: `fundchannel_start` now disallows a non-zero `mindepth` parameter if you ask for a zeroconf `channel_type`.
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c155e42

Really nice idea!

@vincenzopalazzo vincenzopalazzo merged commit 9a4be1a into ElementsProject:master Apr 1, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants