Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pay: fix re-adding payment amount back to estimated capacity #7188

Merged
merged 2 commits into from
Apr 4, 2024
Merged

pay: fix re-adding payment amount back to estimated capacity #7188

merged 2 commits into from
Apr 4, 2024

Commits on Apr 2, 2024

  1. pay: fix removal of channel hint estimated capacity 

    Changelog-Fixed: Plugins: pay now correctly estimates channel capacity
after payment failure, fixing some retry cases.

The `estimated_capacity` was properly substracted from the channel
hint, but adding the amount back did not work. The amount was added back
and then immediately substracted again. This caused the
`estimated_capacity` to ever decrease. This commit makes sure re-adding
the amount to the `estimated_capacity` works as expected.
    @JssDWt
    JssDWt committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    6260052 View commit details
    Browse the repository at this point in the history

  2. tests: add test_pay_avoid_low_fee_chan 

    Tests whether we're able to route around a low-fee channel in the graph. We
should be able to find the more expensive route if the cheaper route is
depleted.
    @JssDWt
    JssDWt committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8433c27 View commit details
    Browse the repository at this point in the history