plugins/clnrest: simple wrapper to handle missing python3. #7211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently NixOS didn't have Python (sometimes!) so let's not assume. By reusing the JSON "parsing" code from cowsay, we can self-disable to handle this case. Reported-by: Shahana Farooqui <shahana.farooqui@gmail.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: Plugins: `clnrest` now correctly self-disables if Python not present at all.
Comment on lines
+1
to
+5
| #! /bin/sh | ||
| # clrest.py neatly exits if we don't have dependencies, but what if we don't | ||
| # have Python itself? | ||
|
|
||
| if ! type python3 > /dev/null 2>&1; then |
There was a problem hiding this comment.
imho this should be standard of every plugin :)
vincenzopalazzo
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
ACK c76bd6c
Apparently NixOS didn't have Python
if someone is using nix in the correct way this should be always true due that the dependencies should be declared inside the binary, and not at the OS level (well this is how I use it, idk if this is the standard way, but I like to believe it 😸 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently NixOS didn't have Python (sometimes!) so let's not assume. By reusing the JSON "parsing" code from cowsay, we can self-disable to handle this case.
Reported-by: Shahana Farooqui shahana.farooqui@gmail.com
Changelog-Fixed: Plugins:
clnrestnow correctly self-disables if Python not present at all.