Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyln-client: Deprecate category, desc and long description from method #7520

Conversation

ShahanaFarooqui
Copy link
Collaborator

@ShahanaFarooqui ShahanaFarooqui commented Aug 3, 2024

Category, description and long description from json_command and plugin_command have been removed in favour of reading them from json schema. Reference PR: #7485

Deprecating them in pyln-client as well. They will be removed completely in future releases.

Changelog-Deprecated: pyln-client: category, description and long descriptions for RPC commands are deprecated now.

@ShahanaFarooqui ShahanaFarooqui added this to the v24.08 milestone Aug 3, 2024
@ShahanaFarooqui ShahanaFarooqui changed the title pyln-client: Deprecate category, description and long description fro… pyln-client: Deprecate category, desc and long description from method Aug 3, 2024
@rustyrussell
Copy link
Contributor

Please change Changelog-None to Changelog-Deprecated: pyln-client: ....

…m method

Category, description and long description from `json_command` and `plugin_command` have been removed in favour of getting them from json schema.  Reference PR: Add categories in RPC documentation ElementsProject#7485

Deprecating them in pyln-client as well. They will remove completely in future releases.

Changelog-Deprecated: pyln-client: category, description and long descriptions for RPC commands are deprecated now.
@rustyrussell rustyrussell merged commit a82f1fe into ElementsProject:master Aug 7, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants