Add strict-forwarding option #7606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagrang3
force-pushed
the
fix-reserve-race
branch
2 times, most recently
from
d6df8d2
to
4170c09
Compare
|
OK, so 495403d, breaks the Shall we add a configuration option to enable/disable non-strict forwarding? |
Lagrang3
force-pushed
the
fix-reserve-race
branch
from
3191f1a
to
abd139a
Compare
Lagrang3
force-pushed
the
fix-reserve-race
branch
from
abd139a
to
d0ca1d7
Compare
|
If the channels have any fee differences, they will also not be considered equivalent. So, varying feerates serves to override, too. This will affect renepay's algorithm too, unfortunately :( |
Changelog-Add: add option dev-strict-forwarding
rustyrussell
force-pushed
the
fix-reserve-race
branch
from
d0ca1d7
to
c415feb
Compare
|
Trivial rebase for silly conflict in test_pay.py. |
vincenzopalazzo
merged commit bc419b4
into
ElementsProject:master
37 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add strict forwarding option
Description
When receiving a forward request lightningd selects the best channel with
the next peer based on its ability to add an HTLC and its spendable amount.
If two forwarding request arrive at the same time pointing to the same
peer we can have a race condition in which both HTLCs compete
concurrently for the same spendable amount.
There shouldn't be a race condition if both requests are supposed to be
allocated on different parallel channels. However, non-strict forwarding is allowed
in the protocol and it is reasonable that node operators can decide which channel
to use when forwarding to a peer.
Therefore we add configuration option
dev-strict-forwardingdefault to false,to enforce strict forwarding. With that flag we no longer need to skip parallel channel
tests in renepay (9d88ce3).
Related Issues
Changes Made
Checklist
Ensure the following tasks are completed before submitting the PR:
TODOshave been addressed or removed.Additional Notes
This is not a solution to the race condition, it only avoids it by removing the freedom to choose the forward channel.