schemas: "description" field in "wait(any)invoice" is optional since BOLT12 #7667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's complaining that the auto-generated files aren't updated, while i really did that. The python output looks way different though. Seems the specific version is needed... |
…BOLT12 For BOLT12 invoices, the "description" is field missing in the invoice responses. Update the schemas accordingly: - `doc/schemas/lightning-waitanyinvoice.json` - `doc/schemas/lightning-waitinvoice.json` Also commit the generated msggen, cln-grpc, cln-rpc and pyln-grpc-proto files. Changelog-Fixed: schemas: Make description in `Wait(any)invoiceResponse` optional to handle BOLT12
|
Are you using |
laanwj
force-pushed
the
2024-09-waitanyinvoice-description-option-2
branch
from
308c173
to
dda7524
Compare
|
Didn't even have that installed, i don't think i've ever used Did manually figure it out i think: |
|
I suggest this goes into 24.08.1 aswell @ShahanaFarooqui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schemas: "description" field in "wait(any)invoice" is optional since BOLT12
Description
For BOLT12 invoices, the "description" is field missing in the invoice responses. This causes a serde parse error when handling BOLT12 invoices in rust code. Update the schemas accordingly:
doc/schemas/lightning-waitanyinvoice.jsondoc/schemas/lightning-waitinvoice.jsonAlso commit the generated msggen, cln-grpc, cln-rpc and pyln-grpc-proto files.
Related Issues
Continues #7660.
Changes Made
Changelog-Fixed: schemas: Make description in
Wait(any)invoiceResponseoptional to handle BOLT12Checklist
Ensure the following tasks are completed before submitting the PR:
TODOshave been addressed or removed.