Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libplugin-pay: use map for channel hints #7726

Merged

Conversation

JssDWt
Copy link
Contributor

@JssDWt JssDWt commented Oct 7, 2024

For nodes with many channels this is a tremendous improvement in pay performance. PR #7611 improves payment performance from 15 seconds to 13.5 seconds on one of our nodes. This commit improves payment performance from 13.5 seconds to 5.7 seconds.

Changelog-Fixed: Improved pathfinding speed for large nodes.

Replaces #7648

Important

Open for merging new PRs until the next PR freeze date is confirmed!

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

For nodes with many channels this is a tremendous improvement in pay
performance. PR ElementsProject#7611 improves payment performance from 15 seconds to
13.5 seconds on one of our nodes. This commit improves payment
performance from 13.5 seconds to 5.7 seconds.

Changelog-Fixed: Improved pathfinding speed for large nodes.
@JssDWt
Copy link
Contributor Author

JssDWt commented Oct 7, 2024

Tagging @cdecker because a merge closed #7648

@cdecker
Copy link
Member

cdecker commented Oct 7, 2024

Thanks @JssDWt for rebuilding this on top of #7494, and sorry for the delay.

ACK 83d1db0

@cdecker cdecker enabled auto-merge (rebase) October 7, 2024 12:44
@cdecker cdecker merged commit cc1362e into ElementsProject:master Oct 7, 2024
38 checks passed
@rustyrussell rustyrussell added this to the v24.08.2 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants