Update emergency.recover after every 'commitment_revocation' so that user can sweep funds by penalty transaction. #7772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi2011
force-pushed
the
enablepenaltytxn
branch
from
bbea1f1 to
ca3b3de
Compare
adi2011
force-pushed
the
enablepenaltytxn
branch
2 times, most recently
from
6c70397 to
eeb239f
Compare
rustyrussell
approved these changes
Nov 17, 2024
wallet/wallet.c
Outdated
|
|
||
| for (u32 pos = 0; pos < chain->chain.num_valid; pos++) { | ||
| struct secret s; | ||
| memcpy(&s, &chain->chain.known[pos].hash, sizeof(s)); |
There was a problem hiding this comment.
We have a new macro for, this: CROSS_TYPE_ASSIGNMENT(&s, &chain->chain.known[pos].hash). It checks the two types are same size...
There was a problem hiding this comment.
Fixed it. Thanks!!
rustyrussell
force-pushed
the
enablepenaltytxn
branch
from
eeb239f to
98b6ae4
Compare
|
Rebased on master with simple API fixes. |
adi2011
force-pushed
the
enablepenaltytxn
branch
2 times, most recently
from
84bebbf to
7f13d7b
Compare
rustyrussell
force-pushed
the
enablepenaltytxn
branch
from
7f13d7b to
6020851
Compare
|
This doesn't work for old scb files (as you can tell, from the test!) It should... |
adi2011
force-pushed
the
enablepenaltytxn
branch
2 times, most recently
from
4312f07 to
51d0031
Compare
adi2011
force-pushed
the
enablepenaltytxn
branch
from
51d0031 to
8c67b5a
Compare
This change will allow subtypes in wiregen files to have tlvstreams. Shifting tlv structs above subtypes in header_template is done to prevent forward declaration. Since generate-wire prepends 'tlv_' in tlvname, we have to modify fromwire_subtype_field and towire_subtype_field in impl_template to accommodate this.
adi2011
force-pushed
the
enablepenaltytxn
branch
from
abaf48b to
1ca3c9b
Compare
…rgencyrecover to create penalty txn when peer publishes an old revoked state.
…chan() - Added field to store commitment secret chain in - Added field to hold counterparty's basepoint information - Added field to indicate the channel initiator's side (local or remote) These fields enhance to make channels which are capable to create penalty transaction in case the peer broadcasts an old revoked state.
…directly to the database
- Adds 'wallet_stub_shachain_init' function to store a retrieved shachain in the database.
- Saves initial metadata ('min_index' and 'num_valid') to the 'shachains' table.
- Iterates through known shachain secrets, adding each entry to 'shachain_known' with position, index, and hash.
This function enables direct persistence of shachain data, ensuring all relevant information is saved upon retrieval.
…mergency.recover using staticbackup RPC
…pdate emergency.recover everytime we get a revocation secret.
Add test to check if we can successfully create a penalty transaction when we recover a channel using emergencyrecover and the peer publishes an old state. Changelog-Added: Now the emergency.recover file would keep track of all the revocation secrets when any channel advances it's state.
adi2011
force-pushed
the
enablepenaltytxn
branch
from
1ca3c9b to
e20a2c3
Compare
niftynei
reviewed
Dec 3, 2024
| #include <common/wireaddr.h> | ||
| #include <common/channel_type.h> | ||
| #include <common/derive_basepoints.h> |
There was a problem hiding this comment.
nit: list these alphabetically?
There was a problem hiding this comment.
for commit 53b16a0, it looks like a keyword got omitted from the commit message
| @@ -1465,9 +1469,13 @@ static struct channel *stub_chan(struct command *cmd, | |||
| struct pubkey localFundingPubkey; | |||
| struct pubkey pk; | |||
| struct short_channel_id *scid; | |||
| u32 blockht; | |||
| u32 blockht = 0; | |||
There was a problem hiding this comment.
why set this here? it doesn't look like it got used again in this commit
| @@ -2368,6 +2368,8 @@ static void json_add_scb(struct command *cmd, | |||
| { | |||
| u8 *scb = tal_arr(cmd, u8, 0); | |||
|
|
|||
| // Update shachain in SCB. | |||
There was a problem hiding this comment.
nit: comments are of form /* Update shachain in SCB. */
| @@ -1013,6 +1013,9 @@ void tell_connectd_peer_importance(struct peer *peer UNNEEDED, | |||
| /* Generated stub for tlv_hsmd_dev_preinit_tlvs_new */ | |||
| struct tlv_hsmd_dev_preinit_tlvs *tlv_hsmd_dev_preinit_tlvs_new(const tal_t *ctx UNNEEDED) | |||
| { fprintf(stderr, "tlv_hsmd_dev_preinit_tlvs_new called!\n"); abort(); } | |||
| /* Generated stub for tlv_scb_tlvs_new */ | |||
| struct tlv_scb_tlvs *tlv_scb_tlvs_new(const tal_t *ctx UNNEEDED) | |||
There was a problem hiding this comment.
nit: squash this into the commit that adds this new method!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would enable nodes to create penalty transaction when the peer publishes an old revoked state using the emergency.recover.
Addresses: #7696