-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testnet4 entry in chainparams #7894
base: master
Are you sure you want to change the base?
Conversation
just as a driveby review comment: we don't use merge commits in CLN (your last commit is a merge commit). we use rebases. you'll need to remove that commit before this PR is eligible for being included in the main branch :) |
8e98ad3
to
ebf3e84
Compare
Rebased on top of master in order to remove the merge commits. I also squashed the two fixups that you had. |
cACK |
Ah, I hate the |
28de1b3
to
1b58069
Compare
eek sorry. I should have checked first |
Don't worry, I was just commenting about my own oversight that I should have selected You're doing good 👍 |
bb0d9e7
to
2957884
Compare
The BIP70 name given as testnet4 to correspond with chaininfo value.
Changelog-Added: Support for Bitcoin `testnet4`
2957884
to
4335275
Compare
Added an entry in chainparams for testnet4
Changelog-Added: entry in chainparams for testnet4
Important
24.11 FREEZE NOVEMBER 7TH: Non-bugfix PRs not ready by this date will wait for 25.02.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: